feat: install phpstan and resolving reported errors in PHPStan

This commit is contained in:
amir-ys
2024-11-07 01:41:19 +03:30
parent b7efa6b24a
commit 865d565a91
27 changed files with 1023 additions and 642 deletions
+3 -2
View File
@@ -2,11 +2,12 @@
namespace App\Services\Media;
use Spatie\MediaLibrary\HasMedia\HasMediaTrait as BasicHasMedia;
use Spatie\MediaLibrary\InteractsWithMedia;
trait HasMediaTrait
{
use BasicHasMedia;
use InteractsWithMedia;
public function main_image()
{
+2 -2
View File
@@ -2,11 +2,11 @@
namespace App\Services\Media;
use Spatie\MediaLibrary\Models\Media as BaseMedia;
use Spatie\MediaLibrary\MediaCollections\Models\Media as BaseMedia;
class Media extends BaseMedia
{
public function getTable()
public function getTable(): string
{
return 'media';
}
+10 -6
View File
@@ -2,18 +2,22 @@
namespace App\Services\Media;
use Spatie\MediaLibrary\Models\Media;
use Spatie\MediaLibrary\PathGenerator\PathGenerator as BasePathGenerator;
use Spatie\MediaLibrary\MediaCollections\Models\Media;
use Spatie\MediaLibrary\Support\PathGenerator\DefaultPathGenerator;
class PathGenerator implements BasePathGenerator
class PathGenerator extends DefaultPathGenerator
{
/*
* Get the path for the given media, relative to the root storage path.
*/
/**
* @param Media $media
* @return string
*/
public function getPath(Media $media): string
{
return md5($media->id).'/';
return md5($media->id) . '/';
}
/*
@@ -21,7 +25,7 @@ class PathGenerator implements BasePathGenerator
*/
public function getPathForConversions(Media $media): string
{
return $this->getPath($media).'conversions/';
return $this->getPath($media) . 'conversions/';
}
/*
@@ -29,7 +33,7 @@ class PathGenerator implements BasePathGenerator
*/
public function getPathForResponsiveImages(Media $media): string
{
return $this->getPath($media).'responsive-images/';
return $this->getPath($media) . 'responsive-images/';
}
}
@@ -3,8 +3,8 @@
namespace App\Services\Media\UrlGenerator;
use DateTimeInterface;
use Spatie\MediaLibrary\UrlGenerator\BaseUrlGenerator;
use Spatie\MediaLibrary\Exceptions\UrlCannotBeDetermined;
use Spatie\MediaLibrary\MediaCollections\Exceptions\InvalidUrlGenerator;
use Spatie\MediaLibrary\Support\UrlGenerator\BaseUrlGenerator;
class FtpUrlGenerator extends BaseUrlGenerator
{
@@ -15,7 +15,7 @@ class FtpUrlGenerator extends BaseUrlGenerator
*/
public function getUrl(): string
{
return config( 'media-library.wm-cdn' ) . '/' . $this->getPathRelativeToRoot();
return config('media-library.wm-cdn') . '/' . $this->getPathRelativeToRoot();
}
/**
@@ -23,13 +23,11 @@ class FtpUrlGenerator extends BaseUrlGenerator
* @param array $options
*
* @return string
*
* @throws UrlCannotBeDetermined
* @throws InvalidUrlGenerator
*/
public function getTemporaryUrl( DateTimeInterface $expiration , array $options = [] ): string
public function getTemporaryUrl(DateTimeInterface $expiration, array $options = []): string
{
throw UrlCannotBeDetermined::filesystemDoesNotSupportTemporaryUrls();
return 'done';
throw new InvalidUrlGenerator();
}
/**
@@ -38,7 +36,7 @@ class FtpUrlGenerator extends BaseUrlGenerator
* @return string
*
*/
public function getPath()
public function getPath(): string
{
return $this->getPathRelativeToRoot();
}
@@ -50,6 +48,6 @@ class FtpUrlGenerator extends BaseUrlGenerator
*/
public function getResponsiveImagesDirectoryUrl(): string
{
return config( 'media-library.wm-cdn' ) . '/' . $this->pathGenerator->getPathForResponsiveImages( $this->media );
return config('media-library.wm-cdn') . '/' . $this->pathGenerator->getPathForResponsiveImages($this->media);
}
}
@@ -3,7 +3,7 @@
namespace App\Services\Media\UrlGenerator;
use DateTimeInterface;
use Spatie\MediaLibrary\UrlGenerator\BaseUrlGenerator;
use Spatie\MediaLibrary\Support\UrlGenerator\BaseUrlGenerator;
class S3UrlGenerator extends BaseUrlGenerator
{
@@ -14,7 +14,7 @@ class S3UrlGenerator extends BaseUrlGenerator
*/
public function getUrl(): string
{
return config( 'media-library.s3.domain' ) . '/' . $this->getPathRelativeToRoot();
return config('media-library.s3.domain') . '/' . $this->getPathRelativeToRoot();
}
/**
@@ -24,7 +24,7 @@ class S3UrlGenerator extends BaseUrlGenerator
* @return string
*
*/
public function getTemporaryUrl( DateTimeInterface $expiration , array $options = [] ): string
public function getTemporaryUrl(DateTimeInterface $expiration, array $options = []): string
{
return 'done';
@@ -48,6 +48,6 @@ class S3UrlGenerator extends BaseUrlGenerator
*/
public function getResponsiveImagesDirectoryUrl(): string
{
return config( 'media-library.s3.domain' ) . '/' . $this->pathGenerator->getPathForResponsiveImages( $this->media );
return config('media-library.s3.domain') . '/' . $this->pathGenerator->getPathForResponsiveImages($this->media);
}
}