From 73d0169ca39d9090569d60a2c343ea3b0a9cfe9f Mon Sep 17 00:00:00 2001 From: Fateme Date: Thu, 23 Jul 2020 19:49:14 +0430 Subject: [PATCH] new correction on access --- app/Http/Controllers/CycleController.php | 4 ++-- app/Http/Controllers/ItemController.php | 6 ++--- app/Http/Controllers/LabelController.php | 10 ++++---- app/Http/Controllers/PackageController.php | 8 +++---- app/Http/Controllers/TestResultController.php | 2 +- .../show/views/TestResult/ShowTestResult.vue | 14 +++++++++-- resources/js/vue/components/core/Toolbar.vue | 5 ++-- .../vue/components/modal/testresult/Show.vue | 23 +++++++++++++++---- resources/js/vue/views/Cycle/List.vue | 15 +++++++++--- resources/js/vue/views/Item/List.vue | 11 ++++++++- resources/js/vue/views/Label/List.vue | 1 + resources/js/vue/views/Package/List.vue | 13 +++++++++-- resources/js/vue/views/TestResult/List.vue | 14 +++++++---- resources/js/vue/views/User/List.vue | 3 ++- 14 files changed, 92 insertions(+), 37 deletions(-) diff --git a/app/Http/Controllers/CycleController.php b/app/Http/Controllers/CycleController.php index 7b0d1308..58496dd4 100644 --- a/app/Http/Controllers/CycleController.php +++ b/app/Http/Controllers/CycleController.php @@ -14,7 +14,7 @@ class CycleController extends Controller $user = auth('api')->user(); $Cycles = Cycle:: - when($user->cant('showAll'), function($query) use ($user) { + when($user->cant('showAll', Cycle::class), function($query) use ($user) { if ($user->hasRole('Supervisor')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); @@ -36,7 +36,7 @@ class CycleController extends Controller ->when($request->has('cycle_number') && $request->cycle_number != '', function($query) use($request){ $query->where('cycle_number', $request->cycle_number); }) - ->when($request->has('medical_center_id') && $request->medical_center_id != '', function($query) use($request){ + ->when($request->has('medical_center_id') && $request->medical_center_id != '' && $request->medical_center_id != 'undefined', function($query) use($request){ $query->whereHas('user', function($query) use ($request) { $query->where('medical_center_id', $request->medical_center_id); }); diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php index 6814ea51..9b14b69e 100644 --- a/app/Http/Controllers/ItemController.php +++ b/app/Http/Controllers/ItemController.php @@ -17,7 +17,7 @@ class ItemController extends Controller return \MessageResponse::error('You dont have access to this section!'); } - $Items = Item::when($user->cant('showAll'), function($query) use ($user) { + $Items = Item::when($user->cant('showAll', Item::class), function($query) use ($user) { if ($user->hasRole('Supervisor')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); @@ -36,7 +36,7 @@ class ItemController extends Controller ->when($request->has('specific') && $request->specific != '', function($query) use($request){ $query->where('specific', $request->specific); }) - ->when($request->has('medical_center_id') && $request->medical_center_id != '', function($query) use($request){ + ->when($request->has('medical_center_id') && $request->medical_center_id != '' && $request->medical_center_id != 'undefined', function($query) use($request){ $query->whereHas('user', function($query) use ($request) { $query->where('medical_center_id', $request->medical_center_id); }); @@ -109,7 +109,7 @@ class ItemController extends Controller return \MessageResponse::data([]); } - $Items = Item::when($user->cant('showAll'), function($query) use ($user) { + $Items = Item::when($user->cant('showAll', Item::class), function($query) use ($user) { if ($user->hasRole('Supervisor')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); diff --git a/app/Http/Controllers/LabelController.php b/app/Http/Controllers/LabelController.php index 2fae9444..87b645c6 100644 --- a/app/Http/Controllers/LabelController.php +++ b/app/Http/Controllers/LabelController.php @@ -13,13 +13,11 @@ class LabelController extends Controller public function index(Request $request) { $user = auth('api')->user(); - $admin_users = User::role('Admin')->get()->pluck('id')->toArray(); - $admin_users[] = $user->id; $Labels = Label:: - when($user->cant('showAll'), function($query) use ($user, $admin_users) { + when($user->cant('showAll', Label::class), function($query) use ($user) { if ($user->hasRole('Supervisor')) { - $query->whereHas('user', function($query) use ($user, $admin_users) { + $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); }); } @@ -39,7 +37,7 @@ class LabelController extends Controller ->when($request->has('label_id') && $request->label_id != '', function($query) use($request){ $query->where('id', $request->label_id); }) - ->when($request->has('medical_center_id') && $request->medical_center_id != '', function($query) use($request){ + ->when($request->has('medical_center_id') && $request->medical_center_id != '' && $request->medical_center_id != 'undefined', function($query) use($request){ $query->whereHas('user', function($query) use ($request) { $query->where('medical_center_id', $request->medical_center_id); }); @@ -117,7 +115,7 @@ class LabelController extends Controller // $admin_users[] = $user->id; $Labels = Label:: - when($user->cant('showAll'), function($query) use ($user) { + when($user->cant('showAll', Label::class), function($query) use ($user) { if ($user->hasRole('Supervisor|User')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); diff --git a/app/Http/Controllers/PackageController.php b/app/Http/Controllers/PackageController.php index 99900bf6..90f4f959 100644 --- a/app/Http/Controllers/PackageController.php +++ b/app/Http/Controllers/PackageController.php @@ -18,7 +18,7 @@ class PackageController extends Controller } $Packages = Package:: - when($user->cant('showAll'), function($query) use ($user) { + when($user->cant('showAll', Package::class), function($query) use ($user) { if ($user->hasRole('Supervisor')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); @@ -31,7 +31,7 @@ class PackageController extends Controller ->when($request->has('package_id') && $request->package_id != '', function($query) use($request){ $query->where('id', $request->package_id); }) - ->when($request->has('medical_center_id') && $request->medical_center_id != '', function($query) use($request){ + ->when($request->has('medical_center_id') && $request->medical_center_id != '' && $request->medical_center_id != 'undefined', function($query) use($request){ $query->whereHas('user', function($query) use ($request) { $query->where('medical_center_id', $request->medical_center_id); }); @@ -159,11 +159,9 @@ class PackageController extends Controller public function getPackages() { $user = auth('api')->user(); - // $admin_users = User::role('Admin')->get()->pluck('id')->toArray(); - // $admin_users[] = $user->id; $Packages = Package:: - when($user->cant('showAll'), function($query) use ($user) { + when($user->cant('showAll', Package::class), function($query) use ($user) { if ($user->hasRole('Supervisor|User')) { $query->whereHas('user', function($query) use ($user) { $query->where('medical_center_id', $user->medical_center_id); diff --git a/app/Http/Controllers/TestResultController.php b/app/Http/Controllers/TestResultController.php index bb419168..b2456bae 100644 --- a/app/Http/Controllers/TestResultController.php +++ b/app/Http/Controllers/TestResultController.php @@ -41,7 +41,7 @@ class TestResultController extends Controller if ($user->hasRole('Supervisor|User')) { $medical_center_id = $user->medical_center_id; } - elseif($request->has('medicalCenter_id') && $request->medicalCenter_id) { + elseif($request->has('medicalCenter_id') && $request->medicalCenter_id != '' && $request->medicalCenter_id != 'undefined' ) { $medical_center_id = $request->medicalCenter_id; } else { $medical_center_id = null; diff --git a/resources/js/show/views/TestResult/ShowTestResult.vue b/resources/js/show/views/TestResult/ShowTestResult.vue index e00a872c..f7fbbe67 100644 --- a/resources/js/show/views/TestResult/ShowTestResult.vue +++ b/resources/js/show/views/TestResult/ShowTestResult.vue @@ -20,7 +20,12 @@
Result : - fas fa-check + + + + + +
verify : - fas fa-times + + + + + + \ No newline at end of file + diff --git a/resources/js/vue/components/modal/testresult/Show.vue b/resources/js/vue/components/modal/testresult/Show.vue index 297bcdf1..fd1fecac 100644 --- a/resources/js/vue/components/modal/testresult/Show.vue +++ b/resources/js/vue/components/modal/testresult/Show.vue @@ -20,7 +20,12 @@
Result : - fas fa-check + + + + + +
verify : - fas fa-times + + + + + + + + - + @@ -175,7 +190,7 @@ Verify - + @@ -97,6 +98,9 @@