fix some problems

app/Http/Controllers/TransferItemController.php

@@ -15,7 +15,8 @@ class TransferItemController extends Controller
 {
     public function getSuspendedTransfer()
     {
-        $data = Transfer::where( "transferable_type" , "App\\Item" )
+        $data = Transfer::query()
+            ->whereHasMorph( 'transferable' , [ Item::class ] )
             ->where( "status" , StatusTypeEnum::SUSPENDED )
             ->with( [ "user" , "transferable" , "transferable.user" ] );
 
@@ -23,8 +24,10 @@ class TransferItemController extends Controller
         if ( $user->hasRole( 'User' ) ) {
             $data = $data->where( "user_id" , $user->id );
         } elseif ( $user->hasRole( 'Supervisor' ) ) {
-            $data = $data->whereHas( 'transferable.user' , function ( $query ) use ( $user ) {
+            $data = $data->whereHasMorph( 'transferable' , [ Item::class ] , function ( $query ) use ( $user ) {
-                $query->where( 'medical_center_id' , $user->medical_center_id );
+                $query->whereHas( 'user' , function ( $query1 ) use ( $user ) {
+                    $query1->where( 'medical_center_id' , $user->medical_center_id );
+                } );
             } );
         }
 
@@ -62,8 +65,10 @@ class TransferItemController extends Controller
             $Item->transfers()->create( [
                 "user_id" => $request->user_id ,
                 "from_date" => Carbon::now() ,
-                "status" => StatusTypeEnum::SUSPENDED
+                "status" => StatusTypeEnum::APPROVED
             ] );
+            if ( $Item->transferActive ) $Item->transferActive()->update( [ "to_date" => Carbon::now() ] );
+            $Item->update( [ "user_id" => $request->user_id ] );
         } else {
             return MessageResponse::error( trans( 'messages.user_denied_transfer' ) );
         }

app/Http/Controllers/TransferPackageController.php

@@ -15,7 +15,8 @@ class TransferPackageController extends Controller
 {
     public function getSuspendedTransfer()
     {
-        $data = Transfer::where( "transferable_type" , "App\\Package" )
+        $data = Transfer::query()
+            ->whereHasMorph( 'transferable' , [ Package::class ] )
             ->where( "status" , StatusTypeEnum::SUSPENDED )
             ->with( [ "user" , "transferable" , "transferable.user" ] );
 
@@ -23,8 +24,10 @@ class TransferPackageController extends Controller
         if ( $user->hasRole( 'User' ) ) {
             $data = $data->where( "user_id" , $user->id );
         } elseif ( $user->hasRole( 'Supervisor' ) ) {
-            $data = $data->whereHas( 'transferable.user' , function ( $query ) use ( $user ) {
+            $data = $data->whereHasMorph( 'transferable' , [ Package::class ] , function ( $query ) use ( $user ) {
-                $query->where( 'medical_center_id' , $user->medical_center_id );
+                $query->whereHas( 'user' , function ( $query1 ) use ( $user ) {
+                    $query1->where( 'medical_center_id' , $user->medical_center_id );
+                } );
             } );
         }
 
@@ -65,8 +68,10 @@ class TransferPackageController extends Controller
             $Package->transfers()->create( [
                 "user_id" => $request->user_id ,
                 "from_date" => Carbon::now() ,
-                "status" => StatusTypeEnum::SUSPENDED
+                "status" => StatusTypeEnum::APPROVED
             ] );
+            if ( $Package->transferActive ) $Package->transferActive()->update( [ "to_date" => Carbon::now() ] );
+            $Package->update( [ "user_id" => $request->user_id ] );
         } else {
             return MessageResponse::error( trans( 'messages.user_denied_transfer' ) );
         }

app/Http/Controllers/UserController.php

@@ -16,17 +16,15 @@ class UserController extends Controller
     public function index( Request $request )
     {
         $user = auth( 'api' )->user();
-        if ( $user->cant( 'list' , User::class ) ) {
-            return MessageResponse::error( trans( 'messages.access_denied' ) );
-        }
 
-        if ( $user->hasRole( 'Supervisor' ) ) {
+        if ( $user->hasRole( 'User' ) or $user->hasRole( 'Supervisor' )  ) {
             $medical_center_id = $user->medical_center_id;
         } elseif ( $request->has( 'medical_center_id' ) && $request->medical_center_id ) {
             $medical_center_id = $request->medical_center_id;
         } else {
             $medical_center_id = null;
         }
+
         $Users = User::when( $request->has( 'name' ) && $request->name , function ( $query ) use ( $request ) {
             $query->where( 'name' , 'LIKE' , '%' . $request->name . '%' );
         } )

app/Policies/UserPolicy.php

@@ -3,7 +3,6 @@
 namespace App\Policies;
 
 use App\User;
-use Doctrine\Tests\Common\Inflector\InflectorTest;
 
 class UserPolicy
 {